Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SecureRequestCustomizer.SslAttributes does not cache cert chain like before #4923

Closed
joakime opened this issue May 29, 2020 · 1 comment · Fixed by #4924
Closed

SecureRequestCustomizer.SslAttributes does not cache cert chain like before #4923

joakime opened this issue May 29, 2020 · 1 comment · Fixed by #4924
Labels
Bug For general bugs on Jetty side Performance Sponsored This issue affects a user with a commercial support agreement

Comments

@joakime
Copy link
Contributor

joakime commented May 29, 2020 •
edited
Loading

Jetty version
9.4.29

Description
When a long lived connection has multiple requests and something accesses the HttpServletRequest.getAttributes("javax.servlet.request.X509Certificate") then the entire Certificate Chain is resolved with each access of the Attributes.

The change in PR #4816 apparently got rid of the SslSession CachedInfo object that made this lookup efficient.

Old code in 9.4.28 looks like this...

https://github.com/eclipse/jetty.project/blob/jetty-9.4.28.v20200408/jetty-server/src/main/java/org/eclipse/jetty/server/SecureRequestCustomizer.java#L299

https://github.com/eclipse/jetty.project/blob/ab228fde9e55e9164c738d7fa121f8ac5acd51c9/jetty-server/src/main/java/org/eclipse/jetty/server/SecureRequestCustomizer.java#L289-L307
@joakime joakime added Bug For general bugs on Jetty side Sponsored This issue affects a user with a commercial support agreement labels May 29, 2020
joakime added a commit that referenced this issue May 29, 2020
@joakime
Issue #4923 - restore caching of SSLSession information for SSL Attri…
c1c2c07 
…butes

Signed-off-by: Joakim Erdfelt <[email protected]>
@joakime joakime linked a pull request May 29, 2020 that will close this issue
Issue #4923 - restore caching of SSLSession information for SSL Attributes #4924
Merged
joakime added a commit that referenced this issue May 29, 2020
@joakime
Issue #4923 - Applying changes requested in PR
6a953e3 
Signed-off-by: Joakim Erdfelt <[email protected]>
joakime added a commit that referenced this issue Jun 1, 2020
@joakime
Issue #4923 - Applying changes requested in PR
b6d24c2 
Signed-off-by: Joakim Erdfelt <[email protected]>
joakime added a commit that referenced this issue Jun 1, 2020
@joakime
Issue #4923 - Applying changes requested in PR
f9b75ff 
Signed-off-by: Joakim Erdfelt <[email protected]>
joakime added a commit that referenced this issue Jun 1, 2020
@joakime
Merge pull request #4924 from eclipse/jetty-9.4.x-4923-sslattributes-…
44d601a 
…cache

Issue #4923 - restore caching of SSLSession information for SSL Attributes
@joakime
Copy link
Contributor Author

joakime commented Jun 4, 2020

Merged into jetty-9.4.x (and merged up to jetty-10.0.x and jetty-11.0.x)

@joakime joakime closed this as completed Jun 4, 2020
@sbordet sbordet mentioned this issue Sep 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For general bugs on Jetty side Performance Sponsored This issue affects a user with a commercial support agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #4923 - restore caching of SSLSession information for SSL Attributes jetty/jetty.project
1 participant
@joakime