Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

servlet context root mapping incorrect #4542

Closed
gregw opened this issue Feb 4, 2020 · 5 comments
Closed

servlet context root mapping incorrect #4542

gregw opened this issue Feb 4, 2020 · 5 comments
Assignees
@olamy @joakime
Labels
TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc)

Comments

@gregw
Copy link
Contributor

gregw commented Feb 4, 2020

As per the testing in jakartaee/servlet#300 we are incorrectly setting the pathInfo for context root matched requests
@gregw gregw added the TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc) label Feb 4, 2020
@gregw
Copy link
Contributor Author

gregw commented Feb 4, 2020

@olamy can you look to see if there is a TCK test for this and are we passing or not? Please comment on the servlet-api thread with any relevant findings.

@olamy
Copy link
Member

olamy commented Feb 16, 2020

@gregw I cannot find anything for this in the TCK tests

@gregw
Copy link
Contributor Author

gregw commented Feb 17, 2020

OK, so we need to write our own test for this and then fix the behaviour. @joakime do you want to have a go at this as I think the PathMapping stuff was last touched by you?

@joakime
Copy link
Contributor

joakime commented Feb 17, 2020

I'll give it a shot. :-)

@joakime joakime self-assigned this Feb 17, 2020
@gregw gregw mentioned this issue Mar 24, 2020
Closed
@gregw
Copy link
Contributor Author

gregw commented Mar 24, 2020

I want to work on something fixable for a bit.... so I'll take this one back.

gregw added a commit that referenced this issue Mar 24, 2020
@gregw
Fixes #4542 Root pathspec mapping pathInfo
7ed43c4 
For the "" root pathspec, the pathinfo should always be the full path and the matched path is ""

Signed-off-by: Greg Wilkins <[email protected]>
gregw added a commit that referenced this issue Mar 30, 2020
@gregw
Fixes #4542 Root pathspec mapping pathInfo (#4705)
e913e79 
* Fixes #4542 Root pathspec mapping pathInfo

For the "" root pathspec, the pathinfo should always be the full path and the matched path is ""

Signed-off-by: Greg Wilkins <[email protected]>

* updates from review

Signed-off-by: Greg Wilkins <[email protected]>
@gregw gregw mentioned this issue Mar 30, 2020
Merged
@gregw gregw closed this as completed Mar 30, 2020
grgrzybek added a commit to ops4j/org.ops4j.pax.web that referenced this issue Jun 8, 2020
@grgrzybek
[tests] Fixing EmbeddedJettyTest after jetty/jetty.project#4542 fix
3ddb523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olamy olamy

@joakime joakime

Labels
TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@olamy @gregw @joakime