Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate SniX509ExtendedKeyManager constructor without SslContextFactory$Server #4325

Closed
joakime opened this issue Nov 18, 2019 · 2 comments
Closed

Deprecate SniX509ExtendedKeyManager constructor without SslContextFactory$Server #4325

joakime opened this issue Nov 18, 2019 · 2 comments
Assignees
@joakime
Labels
Enhancement

Comments

@joakime
Copy link
Contributor

joakime commented Nov 18, 2019

Jetty version
Jetty 9.4.22

Description
It's not possible to have a SniX509ExtendedKeyManager without a SslContextFactory$Server, so the following constructor (where argument 2 is null) should be deprecated in Jetty 9.4.x and removed in Jetty 10.0.x

https://github.com/eclipse/jetty.project/blob/bf2482a7ea55a835788ab4d6ff3643b63b0b0ca8/jetty-util/src/main/java/org/eclipse/jetty/util/ssl/SniX509ExtendedKeyManager.java#L53-L56
@joakime joakime changed the title Deprecate SniX509ExtendedKeyManager constructor without SslContextFactory Deprecate SniX509ExtendedKeyManager constructor without SslContextFactory$Server Nov 18, 2019
@joakime joakime self-assigned this Nov 18, 2019
joakime added a commit that referenced this issue Nov 18, 2019
@joakime
Issue #4325 - X509ExtendedKeyManager exceptions on non-Server SSL
55ad107 
Signed-off-by: Joakim Erdfelt <[email protected]>
@joakime
Copy link
Contributor Author

joakime commented Nov 18, 2019

Opened PR #4326

joakime added a commit that referenced this issue Nov 18, 2019
@joakime
Issue #4325 - X509ExtendedKeyManager exceptions on non-Server SSL
f4d387e 
Signed-off-by: Joakim Erdfelt <[email protected]>
joakime added a commit that referenced this issue Nov 18, 2019
@joakime
Merge pull request #4326 from eclipse/jetty-9.4.x-4325-deprecate-NoSs…
8a30543 
…l-SniX509

Issue #4325 - X509ExtendedKeyManager exceptions on non-Server SSL
@joakime
Copy link
Contributor Author

joakime commented Nov 19, 2019

Merged.

@joakime joakime closed this as completed Nov 19, 2019
@joakime joakime mentioned this issue Nov 20, 2019
Merged
@sbordet sbordet mentioned this issue Dec 3, 2019
Closed
@mkemmerz mkemmerz mentioned this issue Dec 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakime joakime

Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joakime