Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose more WebSocket details in JMX and Server Dump #2504

Closed
joakime opened this issue May 3, 2018 · 3 comments · Fixed by #7058
Closed

Expose more WebSocket details in JMX and Server Dump #2504

joakime opened this issue May 3, 2018 · 3 comments · Fixed by #7058
Assignees

Comments

@joakime
Copy link
Contributor

joakime commented May 3, 2018

In light of the conversation in #2061 more information should be exposed about WebSocket in JMX and even the server dump.

Some initial thoughts ...

  • Each WebSocket Server Container (either Jetty Native or JSR356) should be listed separately.
    • Max Message Size (TEXT / BINARY)
    • Idle Timeouts
    • Registered Potential Endpoints (url-pattern + creator / configurator / endpoint class)
      • URI Template Variables (if using UriTemplatePathSpec)
  • Each Client Container should be listed separately.
  • The Sessions tracked within each Container should be accessible.
  • Each Session details
    • In use Connection implementatino (jetty-io layer, identify type of connection)
    • Network EndPoints (jetty-io layer stuff, which endpoint impl)
    • WebSocket Endpoint (event handler in use, and user object/instance toString)
    • Negotiation Details
      • Request URL
      • URI Template Variable Values
      • Requested / Negotiated Sub Protocols
      • Requested / Negotiated Extensions
    • Idle Timeouts
    • Registered Decoders (if JSR356)
    • Registered Encoders (if JSR356)
    • Registered MessageHandlers (if JSR356)
    • User Properties (if JSR356)
@joakime joakime self-assigned this May 4, 2018
@stale
Copy link

stale bot commented Nov 20, 2019

This issue has been automatically marked as stale because it has been a full year without activit. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale For auto-closed stale issues and pull requests label Nov 20, 2019
@joakime
Copy link
Contributor Author

joakime commented Nov 20, 2019

This still needs to be done.

@stale stale bot removed the Stale For auto-closed stale issues and pull requests label Nov 20, 2019
@gregw gregw assigned lachlan-roberts and unassigned joakime Sep 21, 2020
lachlan-roberts added a commit that referenced this issue Oct 29, 2021
@lachlan-roberts
Copy link
Contributor

@joakime are you sure we want all these details about the session in the dump?

We could have an extremely large number of active sessions and to include all that information could potentially be hundreds of lines of information per session.

Also I don't think we currently have the information available for the Connection and Network Endpoints of each websocket session, not sure how we could do those ones.

lachlan-roberts added a commit that referenced this issue Dec 2, 2021
Issue #2504 - expose more WebSocket details in jetty server dump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants