Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve HttpConnection buffer recycling #12227

Closed
sbordet opened this issue Sep 2, 2024 · 0 comments
Closed

Improve HttpConnection buffer recycling #12227

sbordet opened this issue Sep 2, 2024 · 0 comments
Assignees
@gregw
Labels
Bug For general bugs on Jetty side

Comments

@sbordet
Copy link
Contributor

sbordet commented Sep 2, 2024 •
edited
Loading

Jetty version(s)
12

Description
Following the work in #12216, server-side HttpConnection needs a review of buffer recycling, to make it simpler and more understandable for the future.
@sbordet sbordet added the Bug For general bugs on Jetty side label Sep 2, 2024
@sbordet sbordet mentioned this issue Sep 2, 2024
Merged
@gregw gregw self-assigned this Sep 2, 2024
@gregw gregw mentioned this issue Sep 2, 2024
Closed
sbordet added a commit that referenced this issue Sep 4, 2024
@sbordet
Fixes #12227 - Improve HttpConnection buffer recycling.
6611a7b 
Alternative to #12228.

In this PR, the responsibility to release the buffers is in 2 methods: onFillable() (called when network data is available, and to process the next request) and parseAndFillForContent() (called from Request.read()).

Signed-off-by: Simone Bordet <[email protected]>
@gregw gregw closed this as completed in 6887435 Sep 6, 2024
@github-project-automation github-project-automation bot moved this to ✅ Done in Jetty 12.0.14 Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregw gregw

Labels
Bug For general bugs on Jetty side
Projects
No open projects
Jetty 12.0.14
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve HttpConnection buffer recycling #12227 jetty/jetty.project
2 participants
@gregw @sbordet