Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StdErrAppender should detect exception circular references #11792

Closed
sbordet opened this issue May 14, 2024 · 0 comments · Fixed by #11793
Closed

StdErrAppender should detect exception circular references #11792

sbordet opened this issue May 14, 2024 · 0 comments · Fixed by #11793
Assignees
Labels
Bug For general bugs on Jetty side

Comments

@sbordet
Copy link
Contributor

sbordet commented May 14, 2024

Jetty version(s)
12+

Description
StdErrAppender.appendCause() should detect when exceptions have circular references, to avoid StackOverflowError.

See for example how Throwable.lockedPrintStackTrace() does it.

Furthermore, AsyncContextEvent.addThrowable() should use ExceptionUtil.addSuppressedIfNotAssociated() to avoid possible circular references.

@sbordet sbordet added the Bug For general bugs on Jetty side label May 14, 2024
@lorban lorban moved this to 🏗 In progress in Jetty 12.0.10 (FROZEN) May 15, 2024
lorban added a commit that referenced this issue May 15, 2024
lorban added a commit that referenced this issue May 15, 2024
lorban added a commit that referenced this issue May 15, 2024
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue May 15, 2024
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue May 17, 2024
…f one gets logged (#11793)

#11792 detect loops in throwables to avoid StackOverflowError

Signed-off-by: Ludovic Orban <[email protected]>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.10 (FROZEN) May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
No open projects
Status: ✅ Done
2 participants