Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPE from org.eclipse.jetty.ee8.nested.Request.getRequestURL #11776

Closed
joakime opened this issue May 10, 2024 · 0 comments · Fixed by #11777
Closed

NPE from org.eclipse.jetty.ee8.nested.Request.getRequestURL #11776

joakime opened this issue May 10, 2024 · 0 comments · Fixed by #11777
Assignees
@joakime
Labels
Bug For general bugs on Jetty side Sponsored This issue affects a user with a commercial support agreement

Comments

@joakime
Copy link
Contributor

joakime commented May 10, 2024

Jetty version(s)
12.0.9

Jetty Environment
ee8

Java version/vendor (use: java -version)
Any

OS type/version
Any

Description

Cause: java.lang.NullPointerException: Cannot invoke "String.length()" because "s" is null
StackTrace: 
org.eclipse.jetty.util.AbstractTrie.get(AbstractTrie.java:66)
org.eclipse.jetty.server.Request.getServerPort(Request.java:489)
org.eclipse.jetty.ee8.nested.Request.getServerPort(Request.java:1142)
org.eclipse.jetty.ee8.nested.Request.getRequestURL(Request.java:1088)
@joakime joakime added Bug For general bugs on Jetty side Sponsored This issue affects a user with a commercial support agreement labels May 10, 2024
@joakime joakime self-assigned this May 10, 2024
joakime added a commit that referenced this issue May 10, 2024
@joakime
Issue #11776 - NPE proteection in Request.getServerPort
c6ab71d 
If the HttpURI is scheme-less, the attempt to get the port can result in a NPE
@joakime joakime moved this to 🏗 In progress in Jetty 12.0.10 (FROZEN) May 10, 2024
@joakime joakime mentioned this issue May 10, 2024
Merged
lorban pushed a commit that referenced this issue May 14, 2024
@joakime @lorban
Issue #11776 - NPE proteection in Request.getServerPort
9160108 
If the HttpURI is scheme-less, the attempt to get the port can result in a NPE
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.10 (FROZEN) May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakime joakime

Labels
Bug For general bugs on Jetty side Sponsored This issue affects a user with a commercial support agreement
Projects
No open projects
Jetty 12.0.10 (FROZEN)
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #11776 - NPE protection in Request.getServerPort jetty/jetty.project
1 participant
@joakime