Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure ReadListener is nulled out when AsyncContext is completed. #11766

Closed
joakime opened this issue May 8, 2024 · 0 comments · Fixed by #11775
Closed

Ensure ReadListener is nulled out when AsyncContext is completed. #11766

joakime opened this issue May 8, 2024 · 0 comments · Fixed by #11775
Assignees
@joakime
Labels
Bug For general bugs on Jetty side Sponsored This issue affects a user with a commercial support agreement
Milestone
12.0.x

Comments

@joakime
Copy link
Contributor

joakime commented May 8, 2024

Jetty version(s)
12.0.9

Jetty Environment
ee10 (could be more)

Java version/vendor (use: java -version)
Any

OS type/version
Any

Description
The ReadListener associated with an AsyncContext seems to be held for quite a while and is not effectively garbage collected, causing undue memory pressure on applications with large ReadListener implementations.

We need to review our implementation to ensure that the ReadListener is properly nulled out and can be garbage collected at the earliest moment.
@joakime joakime added Bug For general bugs on Jetty side Sponsored This issue affects a user with a commercial support agreement labels May 8, 2024
@joakime joakime added this to the 12.0.x milestone May 8, 2024
@joakime joakime self-assigned this May 10, 2024
@joakime joakime moved this to 🏗 In progress in Jetty 12.0.10 (FROZEN) May 10, 2024
joakime added a commit that referenced this issue May 10, 2024
@joakime
Issue #11766 - null out ReadListener on recycle to aid GC.
7f9312f
@joakime joakime mentioned this issue May 10, 2024
Merged
joakime added a commit that referenced this issue May 12, 2024
@joakime
Merge pull request #11775 from jetty/fix/12.0.x/readlistener-nullific…
dd611b4 
…ation

Issue #11766 - null out ReadListener on recycle to aid GC.
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.10 (FROZEN) May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakime joakime

Labels
Bug For general bugs on Jetty side Sponsored This issue affects a user with a commercial support agreement
Projects
No open projects
Jetty 12.0.10 (FROZEN)
Status: ✅ Done
Milestone
12.0.x
Development

Successfully merging a pull request may close this issue.

Issue #11766 - null out ReadListener on recycle to aid GC. jetty/jetty.project
1 participant
@joakime