Flaky test ServletTest.testSimpleIdleRead() #11327
Assignees
Labels
Comments
|
The test also erroneously send 11 bytes of data instead of 10, due to the extra |
sbordet
added a commit
that referenced
this issue
Sep 9, 2024
Just improving the test code. The flakyness was likely fixed by the work in #12216 and #12237. Signed-off-by: Simone Bordet <[email protected]>
sbordet
added a commit
that referenced
this issue
Sep 10, 2024
Just improving the test code. The flakyness was likely fixed by the work in #12216 and #12237. Signed-off-by: Simone Bordet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jetty version(s)
12+
Jetty Environment
ee10
Description
See #10945.
The problem is as follows:
The last request does not send the content, so the Servlet is blocked in a read.
The idle timeout fires, and runs the demand callback, which reads the failure, which wakes up the blocked by throwing, which is then caught and handled in
ServletChannel.handleException(), resulting in asendError()that succeeds.In the process above, however, we do not notify the underlying
HttpStreamthat there was a failure.So in case of
HttpStreamOverHTTP1, the underlyingEndPointremains fill interested (because the request was waiting for content that was never sent).When the
sendError()completes successfully,HttpStreamOverHTTP1is succeeded, where it checks if it was fill interested, finding that it was, and aborting with "read pending".The text was updated successfully, but these errors were encountered: