Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPE if MultiPartFormData.setFilesDirectory() is not called #11064

Closed
sbordet opened this issue Dec 14, 2023 · 1 comment · Fixed by #11065
Closed

NPE if MultiPartFormData.setFilesDirectory() is not called #11064

sbordet opened this issue Dec 14, 2023 · 1 comment · Fixed by #11065
Assignees
@sbordet
Labels
Bug For general bugs on Jetty side Sponsored This issue affects a user with a commercial support agreement

Comments

@sbordet
Copy link
Contributor

sbordet commented Dec 14, 2023

Jetty version(s)
12+

Description
If MultiPartFormData.setFilesDirectory() is not called, and parts needs to be saved to disk, a NPE is thrown.

We should emit a better error message and possibly decide on good defaults.
@sbordet sbordet added the Bug For general bugs on Jetty side label Dec 14, 2023
@sbordet sbordet self-assigned this Dec 14, 2023
@sbordet sbordet moved this to 👀 In review in Jetty 12.0.5 - FROZEN Dec 14, 2023
@sbordet sbordet added the Sponsored This issue affects a user with a commercial support agreement label Dec 14, 2023
sbordet added a commit that referenced this issue Dec 14, 2023
@sbordet
Fixes #11064 - Jetty 12: NPE if MultiPartFormData.setFilesDirectory()…
59c70f9 
… is not called.

Now trying to use $JETTY_BASE/work, otherwise throwing IllegalArgumentException with a descriptive message.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet sbordet linked a pull request Dec 14, 2023 that will close this issue
Fixes #11064 - Jetty 12: NPE if MultiPartFormData.setFilesDirectory()… #11065
Merged
@sbordet sbordet moved this from 👀 In review to 🏗 In progress in Jetty 12.0.5 - FROZEN Dec 14, 2023
sbordet added a commit that referenced this issue Dec 14, 2023
@sbordet
Fixes #11064 - Jetty 12: NPE if MultiPartFormData.setFilesDirectory()…
8f019b9 
… is not called.

Now trying to use $JETTY_BASE/work, otherwise throwing IllegalArgumentException with a descriptive message.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Copy link
Contributor Author

sbordet commented Dec 14, 2023

Fixed by #11065.

@sbordet sbordet closed this as completed Dec 14, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.5 - FROZEN Dec 14, 2023
@joakime joakime changed the title Jetty 12: NPE if MultiPartFormData.setFilesDirectory() is not called NPE if MultiPartFormData.setFilesDirectory() is not called Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbordet sbordet

Labels
Bug For general bugs on Jetty side Sponsored This issue affects a user with a commercial support agreement
Projects
No open projects
Jetty 12.0.5 - FROZEN
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #11064 - Jetty 12: NPE if MultiPartFormData.setFilesDirectory()… jetty/jetty.project
1 participant
@sbordet