Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update quiche to 0.18.0 #10557

Closed
zugazagoitia opened this issue Sep 20, 2023 · 5 comments · Fixed by #10570
Closed

Update quiche to 0.18.0 #10557

zugazagoitia opened this issue Sep 20, 2023 · 5 comments · Fixed by #10570
Assignees
@joakime @lorban

Comments

@zugazagoitia
Copy link
Contributor

The last update was in #8695, now 0.18.0 has been released.
It introduces some "breaking" changes that shouldn't affect the final user much.

https://github.com/cloudflare/quiche/releases/tag/0.18.0
@lorban lorban moved this to 🏗 In progress in Jetty 10.0.17 / 11.0.17 FROZEN Sep 21, 2023
@lorban lorban moved this to 🏗 In progress in Jetty 12.0.2 FROZEN Sep 21, 2023
@lorban
Copy link
Contributor

lorban commented Sep 21, 2023

Here are the changes made to the quiche.h C header since our last update: cloudflare/quiche@0.16.0...0.18.0#diff-8677002d221c3e20ec05af5a64f7125a501aade052ab378600fcc3b0a3148c91

No breaking change indeed, so updating to version 0.18.0 should be pretty straightforward.

@joakime
Copy link
Contributor

joakime commented Sep 21, 2023

@lorban jetty-quiche-native update to 0.18.0 exists in PR jetty-project/jetty-quiche-native#66

@lorban
Copy link
Contributor

lorban commented Sep 22, 2023

@joakime Once jetty-quiche-native version 0.18.0 has been released, we can update the dependency in Jetty 10, do the few extra changes needed and merge forward.

lorban added a commit that referenced this issue Sep 22, 2023
@lorban
#10557 upgrade quiche to version 0.18.0
ce54bd1 
Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban mentioned this issue Sep 22, 2023
Merged
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.2 FROZEN Sep 25, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 10.0.17 / 11.0.17 FROZEN Sep 25, 2023
joakime pushed a commit that referenced this issue Sep 25, 2023
@lorban
#10557 upgrade quiche to version 0.18.0 (#10570)
842bbe7 
Signed-off-by: Ludovic Orban <[email protected]>
@lorban
Copy link
Contributor

lorban commented Sep 25, 2023

Fixed in 10.0.x and merged to 11.0.x and 12.0.x.

@zugazagoitia
Copy link
Contributor Author

Swift release, thank you very much!

Let's hope the JDK team invest a little of their time in implementing the protocol natively on Java.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakime joakime

@lorban lorban

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade quiche to version 0.18.0 jetty/jetty.project
3 participants
@joakime @lorban @zugazagoitia