Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review ResourceFactory.newSystemResource(String) behavior & javadoc #10328

Closed
joakime opened this issue Aug 16, 2023 · 1 comment · Fixed by #10533
Closed

Review ResourceFactory.newSystemResource(String) behavior & javadoc #10328

joakime opened this issue Aug 16, 2023 · 1 comment · Fixed by #10533

Comments

@joakime
Copy link
Contributor

joakime commented Aug 16, 2023

Jetty version(s)
12.0.0

Enhancement Description
The ResourceFactory.newSystemResource(String) has a strange implementation, an awkward name, and poor javadoc attempting to explain it. (which seems at odds with each other).

We should review that implementation and attempt to clean it up to be more sane.

@joakime joakime moved this to 🏗 In progress in Jetty 12.0.2 FROZEN Sep 13, 2023
@joakime joakime self-assigned this Sep 13, 2023
joakime added a commit that referenced this issue Sep 15, 2023
+ Create a new ResourceFactory.newClassLoaderResource(String, boolean)
+ Make .newSystemResource(String) use it
+ Make .newClassPathResource(String) use it
+ Deprecate .newSystemResource(String)
+ Deprecate .newClassPathResource(String)
+ Adjust own codebase to not use deprecated methods
@joakime joakime linked a pull request Sep 15, 2023 that will close this issue
joakime added a commit that referenced this issue Sep 20, 2023
* Issue #10328 - Review ResourceFactory.newSystemResource

+ Create a new ResourceFactory.newClassLoaderResource(String, boolean)
+ Make .newSystemResource(String) use it
+ Make .newClassPathResource(String) use it
+ Deprecate .newSystemResource(String)
+ Deprecate .newClassPathResource(String)
+ Adjust own codebase to not use deprecated methods
@joakime
Copy link
Contributor Author

joakime commented Sep 20, 2023

Merged PR #10533

@joakime joakime closed this as completed Sep 20, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.2 FROZEN Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant