Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve migration from Servlets to Handler #10324

Closed
sbordet opened this issue Aug 16, 2023 · 1 comment · Fixed by #10529
Closed

Improve migration from Servlets to Handler #10324

sbordet opened this issue Aug 16, 2023 · 1 comment · Fixed by #10529
Assignees
@sbordet
Labels
Documentation High Priority

Comments

@sbordet
Copy link
Contributor

sbordet commented Aug 16, 2023

Jetty version(s)
12

Description
Follow up on comments in #10298.

There should be a section about file uploads / multipart handling.
@sbordet sbordet added the Bug For general bugs on Jetty side label Aug 16, 2023
@sbordet sbordet self-assigned this Aug 16, 2023
@sbordet sbordet added Documentation and removed Bug For general bugs on Jetty side labels Aug 16, 2023
@joakime joakime moved this to 🏗 In progress in Jetty 12.0.2 FROZEN Sep 13, 2023
sbordet added a commit that referenced this issue Sep 15, 2023
@sbordet
Fixes #10324 - Improve migration from Servlets to Handler.
747b79f 
* Using request.getLength() instead of looking up the Content-Length header.
* Jetty Handler vs Servlet pros.
* Using CompletableFuture (not Promise) in examples.
* Removed unused cruft from tests.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet sbordet linked a pull request Sep 15, 2023 that will close this issue
Fixes #10324 - Improve migration from Servlets to Handler. #10529
Merged
sbordet added a commit that referenced this issue Sep 20, 2023
@sbordet
Fixes #10324 - Improve migration from Servlets to Handler. (#10529)
d1a1663 
* Using request.getLength() instead of looking up the Content-Length header.
* Jetty Handler vs Servlet pros.
* Using CompletableFuture (not Promise) in examples.
* Removed unused cruft from tests.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Copy link
Contributor Author

sbordet commented Sep 20, 2023

Fixed by #10529.

@sbordet sbordet closed this as completed Sep 20, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.2 FROZEN Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbordet sbordet

Labels
Documentation High Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #10324 - Improve migration from Servlets to Handler. jetty/jetty.project
1 participant
@sbordet