Follow up for issue #10933 and associated PR #10949.

Most often failures come from the read side, so failure listeners are now serialized in the _readInvoker. This avoids that a failure while parsing a request (e.g. an early EOF) results in concurrent executions of the invokeOnContentAvailable task and the invokeOnFailureListeners task. Signed-off-by: Simone Bordet <[email protected]>
jetty · Dec 17, 2023 · fbf8ddd · fbf8ddd
1 parent c5e40f5
commit fbf8ddd
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/...y-core/jetty-server/src/main/java/org/eclipse/jetty/server/internal/HttpChannelState.java b/...y-core/jetty-server/src/main/java/org/eclipse/jetty/server/internal/HttpChannelState.java
@@ -428,7 +428,7 @@ public Runnable onFailure(Throwable x)
                 };
 
                 // Serialize all the error actions.
-                task = Invocable.combine(_readInvoker.offer(invokeOnContentAvailable), _writeInvoker.offer(invokeWriteFailure), invokeOnFailureListeners);
+                task = Invocable.combine(_readInvoker.offer(invokeOnContentAvailable), _writeInvoker.offer(invokeWriteFailure), _readInvoker.offer(invokeOnFailureListeners));
             }
         }