Issue #7414 Deprecate QoSFilter setters (#7506)

* Issue #7414 Deprecate QoSFilter setters Signed-off-by: Jan Bartel <[email protected]>
jetty · Feb 8, 2022 · c742c2e · c742c2e
1 parent bdc60ee
commit c742c2e
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/QoSFilter.java b/jetty-servlets/src/main/java/org/eclipse/jetty/servlets/QoSFilter.java
@@ -293,10 +293,12 @@ public long getWaitMs()
      * for the semaphore to become available before suspending a request.
      *
      * @param value wait time (in milliseconds)
+     * @deprecated use init-param waitMs instead
      */
+    @Deprecated
     public void setWaitMs(long value)
     {
-        _waitMs = value;
+        LOG.warn("Setter ignored: use waitMs init-param for QoSFilter");
     }
 
     /**
@@ -316,10 +318,12 @@ public long getSuspendMs()
      * a request for while waiting for the semaphore to become available.
      *
      * @param value suspend time (in milliseconds)
+     * @deprecated use init-param suspendMs instead
      */
+    @Deprecated
     public void setSuspendMs(long value)
     {
-        _suspendMs = value;
+        LOG.warn("Setter ignored: use suspendMs init-param for QoSFilter");
     }
 
     /**
@@ -339,11 +343,12 @@ public int getMaxRequests()
      * at the same time.
      *
      * @param value the number of requests
+     * @deprecated use init-param maxRequests instead
      */
+    @Deprecated
     public void setMaxRequests(int value)
     {
-        _passes = new Semaphore((value - getMaxRequests() + _passes.availablePermits()), true);
-        _maxRequests = value;
+        LOG.warn("Setter ignored: use maxRequests init-param for QoSFilter instead");
     }
 
     private class QoSAsyncListener implements AsyncListener