Skip to content

Commit

Permalink
Merge pull request #12602 from jetty/fix/jetty-12.1.x/fix-incorrect-m…
Browse files Browse the repository at this point in the history
…aven-coordinates

Fix incorrect maven coordinates
  • Loading branch information
olamy authored Dec 2, 2024
2 parents 2a40114 + 6c611ac commit a147d83
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 18 deletions.
24 changes: 12 additions & 12 deletions jetty-ee10/jetty-ee10-demos/jetty-ee10-demo-embedded/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -80,36 +80,36 @@
<artifactId>jetty-ee10-webapp</artifactId>
</dependency>
<dependency>
<groupId>org.eclipse.jetty.ee10.demos</groupId>
<artifactId>jetty-ee10-demo-async-rest-webapp</artifactId>
<groupId>org.eclipse.jetty.demos</groupId>
<artifactId>jetty-servlet5-demo-async-rest-webapp</artifactId>
<version>${project.version}</version>
<type>war</type>
</dependency>
<dependency>
<groupId>org.eclipse.jetty.ee10.demos</groupId>
<artifactId>jetty-ee10-demo-jndi-webapp</artifactId>
<groupId>org.eclipse.jetty.demos</groupId>
<artifactId>jetty-servlet5-demo-jndi-webapp</artifactId>
<version>${project.version}</version>
<type>war</type>
</dependency>
<dependency>
<groupId>org.eclipse.jetty.ee10.demos</groupId>
<artifactId>jetty-ee10-demo-jsp-webapp</artifactId>
<groupId>org.eclipse.jetty.demos</groupId>
<artifactId>jetty-servlet5-demo-jsp-webapp</artifactId>
<version>${project.version}</version>
<type>war</type>
</dependency>
<dependency>
<groupId>org.eclipse.jetty.ee10.demos</groupId>
<artifactId>jetty-ee10-demo-mock-resources</artifactId>
<groupId>org.eclipse.jetty.demos</groupId>
<artifactId>jetty-servlet5-demo-mock-resources</artifactId>
</dependency>
<dependency>
<groupId>org.eclipse.jetty.ee10.demos</groupId>
<artifactId>jetty-ee10-demo-simple-webapp</artifactId>
<groupId>org.eclipse.jetty.demos</groupId>
<artifactId>jetty-servlet5-demo-simple-webapp</artifactId>
<version>${project.version}</version>
<type>war</type>
</dependency>
<dependency>
<groupId>org.eclipse.jetty.ee10.demos</groupId>
<artifactId>jetty-ee10-demo-spec-webapp</artifactId>
<groupId>org.eclipse.jetty.demos</groupId>
<artifactId>jetty-servlet5-demo-spec-webapp</artifactId>
<version>${project.version}</version>
<type>war</type>
</dependency>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1696,12 +1696,14 @@ public void testXmlDeployWarNotInWebapps(String env) throws Exception
};

// Put war into ${jetty.base}/wars/ directory
Path srcWar = ("ee8".equals(env)
? distribution.resolveArtifact("org.eclipse.jetty.demos:jetty-servlet4-demo-simple-webapp:war:" + jettyVersion) : distribution.resolveArtifact("org.eclipse.jetty.demos:jetty-servlet5-demo-simple-webapp:war:" + jettyVersion));
String coordinates = "org.eclipse.jetty.demos:jetty-%s-demo-simple-webapp:war:%s".formatted(
"ee8".equals(env) ? "servlet4" : "servlet5",
jettyVersion
);
Path warsDir = jettyBase.resolve("wars");
FS.ensureDirExists(warsDir);
Path destWar = warsDir.resolve("demo.war");
Files.copy(srcWar, destWar);
Files.copy(distribution.resolveArtifact(coordinates), destWar);

// Create XML for deployable
String xml = """
Expand Down Expand Up @@ -2169,7 +2171,7 @@ public void testEagerMultiPartContentHandler(HttpVersion httpVersion) throws Exc
}

@ParameterizedTest
@ValueSource(strings = {"ee8", "ee9", "ee10"})
@ValueSource(strings = {"ee8", "ee9", "ee10", "ee11"})
public void testLimitHandlers(String env) throws Exception
{
String jettyVersion = System.getProperty("jettyVersion");
Expand All @@ -2196,8 +2198,11 @@ public void testLimitHandlers(String env) throws Exception
""";
Files.writeString(jettyLogging, loggingConfig, StandardOpenOption.TRUNCATE_EXISTING);

Path war = distribution.resolveArtifact("org.eclipse.jetty." + env + ".demos:jetty-" + env + "-demo-simple-webapp:war:" + jettyVersion);
distribution.installWar(war, "test");
String coordinates = "org.eclipse.jetty.demos:jetty-%s-demo-simple-webapp:war:%s".formatted(
"ee8".equals(env) ? "servlet4" : "servlet5",
jettyVersion
);
distribution.installWar(distribution.resolveArtifact(coordinates), "test");

int port = Tester.freePort();
try (JettyHomeTester.Run run2 = distribution.start("jetty.http.selectors=1", "jetty.http.port=" + port))
Expand Down

0 comments on commit a147d83

Please sign in to comment.