Skip to content

Commit

Permalink
Bump tycho-p2-repository-plugin from 2.7.1 to 2.7.2 (#7945)
Browse files Browse the repository at this point in the history 
Bumps tycho-p2-repository-plugin from 2.7.1 to 2.7.2.

---
updated-dependencies:
- dependency-name: org.eclipse.tycho:tycho-p2-repository-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
  • Loading branch information
@dependabot
dependabot[bot] authored May 3, 2022
1 parent 75f5cc6 commit 594b96c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion jetty-p2/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<description>Generates a (maven based) P2 Updatesite</description>
<packaging>pom</packaging>
<properties>
<tycho-version>2.7.1</tycho-version>
<tycho-version>2.7.2</tycho-version>

This comment has been minimized.

Sign in to view

Copy link
@laeubi

laeubi May 4, 2022

Contributor

We discovered an issue in the 2.7.1 / 2.7.2 in the update-site generation that unnecessarily might include bundles in the update-site, so please be aware if preparing an release:

eclipse-tycho/tycho#932

This comment has been minimized.

Sign in to view

Copy link
@joakime

joakime May 4, 2022

Contributor

@laeubi thank you for the notice.

If we run a release with this quirk, will it impact users of the p2 artifacts?

This comment has been minimized.

Sign in to view

Copy link
@laeubi

laeubi May 4, 2022

Contributor

The most notable impact will the that the p2-site.zip is much larger than required because it includes all bundles (even though they will never be used due to the mapping rule...).

This comment has been minimized.

Sign in to view

Copy link
@joakime

joakime May 4, 2022

Contributor

I'm ok with a larger p2-site.zip if you are.
Or do you want us to downgrade to 2.7.0 if we release before 2.7.3 is out?

This comment has been minimized.

Sign in to view

Copy link
@joakime

joakime May 4, 2022

Contributor

I suspect the bad sha (from -javadoc.jar) is probably the reason we don't use 2.7.0 right now.

This comment has been minimized.

Sign in to view

Copy link
@laeubi

laeubi May 4, 2022

Contributor

Yes larger artifact is not good but actually probably don't harm I'll try to get a fix out ASAP so hopefully before the next jetty release :-)
</properties>
<build>
<plugins>
Expand Down

0 comments on commit 594b96c

Please sign in to comment.