Skip to content

Commit

Permalink
#8695: make sure the Foreign binding is used for testing when runnin…
Browse files Browse the repository at this point in the history
…g on JDK 17 and not any older nor a more recent version.

Signed-off-by: Ludovic Orban <[email protected]>
  • Loading branch information
lorban committed Oct 18, 2022
1 parent 15e90ac commit 3c6c83d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 22 deletions.
26 changes: 5 additions & 21 deletions jetty-quic/quic-client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,12 @@
<profile>
<id>jdk17</id>
<activation>
<jdk>[17,)</jdk>
<jdk>17</jdk>
</activation>
<!--
This profile makes sure the Foreign binding is used for tests when running exactly on JDK 17.
Older and newer JDKs will revert to the JNA binding.
-->
<dependencies>
<dependency>
<groupId>org.eclipse.jetty.quic</groupId>
Expand All @@ -79,25 +83,5 @@
</plugins>
</build>
</profile>
<profile>
<!-- Don't use the Foreign binding if the JDK version != 17. -->
<id>jdk18+</id>
<activation>
<jdk>[18,)</jdk>
</activation>
<build>
<plugins>
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<argLine>
@{argLine}
${jetty.surefire.argLine}
</argLine>
</configuration>
</plugin>
</plugins>
</build>
</profile>
</profiles>
</project>
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
changed both its API (18) and its name (19), so tests are disabled on JDKs over 17.
Eventually, new Foreign modules for JDKs 18 and 19 should be added.
-->
<id>jdk18+</id>
<id>jdk18</id>
<activation>
<jdk>[18,)</jdk>
</activation>
Expand Down

0 comments on commit 3c6c83d

Please sign in to comment.