h2s spec maven plugin 1.0.0 with h2spec 2.6.0 (#5231)

* use our fork of h2spec-maven-plugin and upgrade version Signed-off-by: olivier lamy <[email protected]> * add a profile to run spec server Signed-off-by: olivier lamy <[email protected]> * use h2spec plugin new version Signed-off-by: olivier lamy <[email protected]> * version h2spec 1.0.0 Signed-off-by: olivier lamy <[email protected]> * exclude specs we know not working Signed-off-by: olivier lamy <[email protected]> * use our own package name Signed-off-by: olivier lamy <[email protected]> * test no exclusion Signed-off-by: olivier lamy <[email protected]> * restore known failure Signed-off-by: olivier lamy <[email protected]> * h2spec maven plugin version 1.0.0 Signed-off-by: olivier lamy <[email protected]> * change default port for manual testing Signed-off-by: olivier lamy <[email protected]>
jetty · Sep 14, 2020 · 3849a91 · 3849a91
1 parent 26d50c8
commit 3849a91
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 3 deletions.
diff --git a/jetty-http2/http2-server/pom.xml b/jetty-http2/http2-server/pom.xml
@@ -12,16 +12,21 @@
 
   <properties>
     <bundle-symbolic-name>${project.groupId}.server</bundle-symbolic-name>
+    <manual.test.port>28888</manual.test.port>
   </properties>
 
   <build>
     <plugins>
       <plugin>
-        <groupId>com.github.madgnome</groupId>
+        <groupId>org.mortbay.jetty</groupId>
         <artifactId>h2spec-maven-plugin</artifactId>
         <configuration>
           <mainClass>org.eclipse.jetty.http2.server.H2SpecServer</mainClass>
           <skip>${skipTests}</skip>
+          <junitPackage>org.eclipse.jetty.h2spec</junitPackage>
+          <excludeSpecs>
+            <excludeSpec>3.5 - Sends invalid connection preface</excludeSpec>
+          </excludeSpecs>
         </configuration>
         <executions>
           <execution>
@@ -78,4 +83,34 @@
     </dependency>
   </dependencies>
 
+  <profiles>
+    <profile>
+      <id>run-spec-server</id>
+      <build>
+        <plugins>
+          <plugin>
+            <groupId>org.codehaus.mojo</groupId>
+            <artifactId>exec-maven-plugin</artifactId>
+            <executions>
+              <execution>
+                <id>spec-server-run</id>
+                <phase>test</phase>
+                <configuration>
+                  <mainClass>org.eclipse.jetty.http2.server.H2SpecServer</mainClass>
+                  <classpathScope>test</classpathScope>
+                  <arguments>
+                    <argument>${manual.test.port}</argument>
+                  </arguments>
+                </configuration>
+                <goals>
+                  <goal>java</goal>
+                </goals>
+              </execution>
+            </executions>
+          </plugin>
+        </plugins>
+      </build>
+    </profile>
+  </profiles>
+
 </project>
diff --git a/pom.xml b/pom.xml
@@ -939,9 +939,9 @@
           </configuration>
         </plugin>
         <plugin>
-          <groupId>com.github.madgnome</groupId>
+          <groupId>org.mortbay.jetty</groupId>
           <artifactId>h2spec-maven-plugin</artifactId>
-          <version>0.6</version>
+          <version>1.0.0</version>
         </plugin>
       </plugins>
     </pluginManagement>