Updates from review

jetty · May 6, 2024 · 34e1ea2 · 34e1ea2
1 parent 061be04
commit 34e1ea2
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 9 deletions.
diff --git a/jetty-core/jetty-server/src/main/config/etc/jetty-threadpool-all-virtual.xml b/jetty-core/jetty-server/src/main/config/etc/jetty-threadpool-all-virtual.xml
@@ -9,7 +9,7 @@
   <Call class="org.slf4j.LoggerFactory" name="getLogger">
     <Arg>org.eclipse.jetty</Arg>
     <Call name="info">
-      <Arg>Virtual threads enabled. Using all virtual threads.</Arg>
+      <Arg>Virtual threads enabled. Using virtual threads for all Jetty tasks.</Arg>
     </Call>
   </Call>
 </Configure>
diff --git a/jetty-core/jetty-server/src/main/config/etc/jetty-threadpool-virtual.xml b/jetty-core/jetty-server/src/main/config/etc/jetty-threadpool-virtual.xml
@@ -37,7 +37,7 @@
   <Call class="org.slf4j.LoggerFactory" name="getLogger">
     <Arg>org.eclipse.jetty</Arg>
     <Call name="info">
-      <Arg>Virtual threads are enabled.</Arg>
+      <Arg>Virtual threads enabled. Using virtual threads only for application tasks.</Arg>
     </Call>
   </Call>
 </Configure>
diff --git a/jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/thread/TrackingExecutor.java b/jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/thread/TrackingExecutor.java
@@ -29,7 +29,7 @@ public class TrackingExecutor implements Executor, Dumpable
     private final Set<Thread> _threads = ConcurrentHashMap.newKeySet();
     private boolean _detailed;
 
-    TrackingExecutor(Executor executor, boolean detailed)
+    public TrackingExecutor(Executor executor, boolean detailed)
     {
         _threadFactoryExecutor = executor;
         _detailed = detailed;

diff --git a/jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/thread/VirtualThreadPool.java b/jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/thread/VirtualThreadPool.java
@@ -71,18 +71,24 @@ public void setName(String name)
         _name = name;
     }
 
+    /**
+     *
+     * @return {@code true} if the virtual threads will be tracked.
+     * @see TrackingExecutor
+     */
+    @ManagedAttribute("virtual threads are tracked")
+    public boolean isTracking()
+    {
+        return _tracking;
+    }
+
     public void setTracking(boolean tracking)
     {
         if (isRunning())
             throw new IllegalStateException(getState());
         _tracking = tracking;
     }
 
-    public boolean isTracking()
-    {
-        return _tracking;
-    }
-
     @ManagedAttribute("reports additional details in the dump")
     public boolean isDetailedDump()
     {
@@ -99,7 +105,7 @@ public void setDetailedDump(boolean detailedDump)
     @Override
     protected void doStart() throws Exception
     {
-        _main = new Thread("keepalive")
+        _main = new Thread("jetty-virtual-thread-pool-keepalive")
         {
             @Override
             public void run()