Issue #7269 - LocalConnector bad assumptions

Signed-off-by: Joakim Erdfelt <[email protected]>
jetty · Dec 14, 2021 · 19f4e74 · 19f4e74
1 parent d40a97e
commit 19f4e74
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/jetty-server/src/test/java/org/eclipse/jetty/server/ProxyConnectionTest.java b/jetty-server/src/test/java/org/eclipse/jetty/server/ProxyConnectionTest.java
@@ -180,7 +180,7 @@ public void testLocalV2(RequestProcessor p) throws Exception
 
         assertThat(response, Matchers.containsString("HTTP/1.1 200"));
         assertThat(response, Matchers.containsString("pathInfo=/path"));
-        assertThat(response, Matchers.containsString("local=0.0.0.0:0"));
+        assertThat(response, Matchers.containsString("local=0.0.0.0:-1")); // LocalConnector has no local host or local port
         assertThat(response, Matchers.containsString("remote=0.0.0.0:0"));
     }
 

diff --git a/jetty-server/src/test/java/org/eclipse/jetty/server/RequestTest.java b/jetty-server/src/test/java/org/eclipse/jetty/server/RequestTest.java
@@ -1002,7 +1002,7 @@ public boolean check(HttpServletRequest request, HttpServletResponse response)
         assertEquals("[::1]", results.get(i++));
         assertEquals("8888", results.get(i++));
         assertEquals("0.0.0.0", results.get(i++));
-        assertEquals("0", results.get(i));
+        assertEquals("-1", results.get(i)); // local connector has no local port
 
         _normalizeAddress = false;
         results.clear();
@@ -1019,7 +1019,7 @@ public boolean check(HttpServletRequest request, HttpServletResponse response)
         assertEquals("[::1]", results.get(i++));
         assertEquals("8888", results.get(i++));
         assertEquals("0.0.0.0", results.get(i++));
-        assertEquals("0", results.get(i));
+        assertEquals("-1", results.get(i)); // local connector has no local port
     }
 
     @Test