Chore/update-eslint-to-flat-config #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly just a reformat from a code mod tool, but there were a couple other modifications made to fix linting
Some of our linting rules became more strict and required refactors and opting out of specific instances
I am not 100% sure if this code path is exposed or not, but if it was then it was broken.
|
Report too large to display inline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update eslint to the flatfile configuration format.
This involved a number of code changes since there are some rules that are slightly more strict or linting may not have even worked in some cases for some libraries.
This process uncovered a bug in the verifyEmailViaLink controller function where the search for pendingVerification would always be false.
I am not 100% sure if this code path is exposed or not, but if it was then it was broken.