Use our own logger instance instead of the standard logger #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Ramlot <[email protected]>
|
Thanks for fixing this. The changes look OK to me, I haven't tested them. I'll have this merged to master and rebase #552 onto it and test it. |
maelvls
approved these changes
Aug 20, 2024
maelvls
added a commit
that referenced
this pull request
Aug 20, 2024
maelvls
added a commit
that referenced
this pull request
Aug 20, 2024
maelvls
added a commit
that referenced
this pull request
Aug 20, 2024
maelvls
added a commit
that referenced
this pull request
Aug 20, 2024
maelvls
added a commit
that referenced
this pull request
Aug 20, 2024
maelvls
added a commit
that referenced
this pull request
Aug 20, 2024
3 tasks
maelvls
added a commit
that referenced
this pull request
Aug 22, 2024
Co-authored-by: Richard Wall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: VC-35375
This prevents issues caused by external libraries which reconfigure the standard logger.
For example, in #552, we saw that all log messages were prefixed with "vCert: ".