Makefile Modules: Change nothing except for Makefile moved to make/02_mod.mk
#555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maelvls
force-pushed
the
step1-makefile-modules
branch
3 times, most recently
from
937f974 to
dcf90f4
Compare
The Makefile was just renamed to make/02_mod.mk, nothing else has changed (except for the relative paths that were changed to $(ROOT_DIR)). The goal is to migrate more and more to native makefile-modules targets without having to migrate the whole thing at once.
maelvls
force-pushed
the
step1-makefile-modules
branch
from
dcf90f4 to
8694365
Compare
|
Ooof that's a lot of work to fix Closing for now. |
|
@maelvls the PR looks good from a Makefile modules perspective. Let's keep it as reference for when we have a bit more time to figure out these buildx, qemu etc. tools. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefile Modules are too tempting, I want to tap into them, especially the tools module.
As a first "baby" step, I propose to move
Makefiletomake/02_mod.mk: nothing else changes. The GitHub Actions are the same, the old targets inMakefilework the same.My idea is to migrate more and more to native makefile-modules targets without having to migrate the whole thing at once.