Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VC-32659] Remove the default CPU limit #539

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented May 29, 2024

In https://docs.venafi.cloud/vaas/k8s-components/c-k8s-components-best-practice/#cpu we say:

Read Stop Using CPU Limits on Kubernetes, to learn why the best practice is to set CPU requests, but not limits.

So I've removed the default CPU limit from the chart values for venafi-kubernetes-agent.

I have not changed the jetstack-agent charts, because I think it is now considered legacy.

I also removed the note about using vertical pod autoscaler, because it seems irrelevant. We don't mention VPA in the documentation or in the other charts AFAIK.

wallrj added 2 commits May 29, 2024 10:38
Signed-off-by: Richard Wall <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
@wallrj wallrj requested a review from hawksight May 29, 2024 09:47
@wallrj wallrj changed the title Remove the default CPU limit [VC-32659] Remove the default CPU limit May 29, 2024
Copy link
Contributor

@hawksight hawksight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having read through I think I agree.
Ultimately the choice is down to the platform team and their policy around what to set and not set.

The bonus here is that we are less likely to have a new install in a large cluster killed for resource starvation (of CPU) and require debugging.

@maelvls
Copy link
Member

maelvls commented Jun 27, 2024

@tfadeyi Hey, I'm not sure whether this needs to be reviewed by you, WDYT?

Copy link
Member

@maelvls maelvls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change, it's a good idea to not set CPU limits by default... especially because none of the "pros" for using CPU limits apply to the Venafi Agent: avoiding reliance on unpredictable spare cpu cycles due to low cpu requests; getting more predictable QoS; being able to charge back on multi-tenant environment.

@tfadeyi
Copy link
Contributor

tfadeyi commented Jun 28, 2024

LGTM

I don't think it requires my approval, I think @wallrj should have permission to merge

@wallrj wallrj merged commit 9e5b087 into jetstack:master Jun 28, 2024
4 checks passed
@wallrj wallrj deleted the remove-cpu-limit branch June 28, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants