Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): Add PodDisruptionBudget option to helm chart #516

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

SgtCoDFish
Copy link
Contributor

This brings the agent into line with many other open source charts (see e.g. cert-manager).

We document this as a best practice here:
https://docs.venafi.cloud/vaas/k8s-components/c-k8s-components-best-practice/#poddisruptionbudget

This is largely adapted from https://github.com/cert-manager/trust-manager/tree/main/deploy/charts/trust-manager !

This brings the agent into line with many other open source charts (see
e.g. cert-manager).

We document this as a best practice here:
https://docs.venafi.cloud/vaas/k8s-components/c-k8s-components-best-practice/#poddisruptionbudget

Signed-off-by: Ashley Davis <[email protected]>
@SgtCoDFish SgtCoDFish changed the title add PodDisruptionBudget option to helm chart feat(helm): add PodDisruptionBudget option to helm chart Mar 5, 2024
@SgtCoDFish SgtCoDFish changed the title feat(helm): add PodDisruptionBudget option to helm chart feat(helm): Add PodDisruptionBudget option to helm chart Mar 5, 2024
Copy link
Member

@sitaramkm sitaramkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SgtCoDFish I could be seeing this wrong - I am running version 0.1.45 atm. Your proposed changes need to go into 46? Or is there some inconsistency in the versions someplace?

@SgtCoDFish
Copy link
Contributor Author

I could be seeing this wrong - I am running version 0.1.45 atm. Your proposed changes need to go into 46? Or is there some inconsistency in the versions someplace?

I think this is because I ran make update-helm-docs which picked up the latest version number. I'm not actually proposing to change the version number in this PR (which would involve a change to Chart.yaml) - we'll bump that later.

Basically I think I'm just bringing the docs up to date here, not changing the version number.

![Version: 0.1.44](https://img.shields.io/badge/Version-0.1.44-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.1.44](https://img.shields.io/badge/AppVersion-v0.1.44-informational?style=flat-square)
![Version: 0.1.45](https://img.shields.io/badge/Version-0.1.45-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.1.45](https://img.shields.io/badge/AppVersion-v0.1.45-informational?style=flat-square)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: version bumps come from running make update-helm-docs - looks like they weren't bumped previously!

@SgtCoDFish SgtCoDFish merged commit 61a66a9 into jetstack:master Mar 6, 2024
4 checks passed
@SgtCoDFish SgtCoDFish deleted the pdb branch March 6, 2024 10:04
@SgtCoDFish
Copy link
Contributor Author

Cheers Olu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants