Skip to content

Commit

Permalink
[Ephemeral Storage] Add request for minimum size of ephemeral storage… (
Browse files Browse the repository at this point in the history
#56)

… for Medium+ instances

## Summary

Medium-Plus instance projects may likely require more disk space. So,
make a minimum request of 8GB.

Ping internally for additional motivations.

## How was it tested?

Did not test.
Tried compiling (but fails on x86-darwin for nix reasons; looking into
it)

## Is this change backwards-compatible?

yes
  • Loading branch information
savil authored Aug 30, 2023
1 parent 3a1d7df commit 1c7247e
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 9 deletions.
18 changes: 9 additions & 9 deletions devbox.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,22 @@
"lockfile_version": "1",
"packages": {
"buf@latest": {
"last_modified": "2023-06-29T16:20:38Z",
"resolved": "github:NixOS/nixpkgs/3c614fbc76fc152f3e1bc4b2263da6d90adf80fb#buf",
"last_modified": "2023-08-10T15:58:45Z",
"resolved": "github:NixOS/nixpkgs/4d2389b927696ef8da4ef76b03f2d306faf87929#buf",
"source": "devbox-search",
"version": "1.21.0"
"version": "1.26.1"
},
"go@latest": {
"last_modified": "2023-06-29T16:20:38Z",
"resolved": "github:NixOS/nixpkgs/3c614fbc76fc152f3e1bc4b2263da6d90adf80fb#go",
"last_modified": "2023-08-22T06:04:29Z",
"resolved": "github:NixOS/nixpkgs/9d757ec498666cc1dcc6f2be26db4fd3e1e9ab37#go_1_21",
"source": "devbox-search",
"version": "1.20.5"
"version": "1.21.0"
},
"golangci-lint@latest": {
"last_modified": "2023-06-29T16:20:38Z",
"resolved": "github:NixOS/nixpkgs/3c614fbc76fc152f3e1bc4b2263da6d90adf80fb#golangci-lint",
"last_modified": "2023-08-22T06:04:29Z",
"resolved": "github:NixOS/nixpkgs/9d757ec498666cc1dcc6f2be26db4fd3e1e9ab37#golangci-lint",
"source": "devbox-search",
"version": "1.53.3"
"version": "1.54.2"
}
}
}
7 changes: 7 additions & 0 deletions padcli/helm/helm.go
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,13 @@ func (hvc *ValueComputer) Compute(ctx context.Context) error {
websvc.GetInstanceType().Memory(),
)

if *websvc.GetInstanceType() == jetconfig.InstanceType_MEDIUM_PLUS {
setNestedFieldPath(
hvc.appValues,
[]string{"resources", "requests", "ephemeral-storage"},
"10Gi",
)
}
hvc.appValues["podPort"] = websvc.GetPort()
} else {
// This logic will change once we allow multiple services
Expand Down

0 comments on commit 1c7247e

Please sign in to comment.