Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 61: allow property type in user property to be a python enum and translate it to a jsonschema enum #64

Conversation

jtv8
Copy link
Contributor

@jtv8 jtv8 commented Mar 12, 2021

No description provided.

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #64 (a35045c) into master (0a521c6) will increase coverage by 0.11%.
The diff coverage is 94.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   91.65%   91.76%   +0.11%     
==========================================
  Files          30       31       +1     
  Lines         563      595      +32     
==========================================
+ Hits          516      546      +30     
- Misses         47       49       +2     
Flag Coverage Δ
unittests 91.76% <94.28%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wysdom/dom/DOMObject.py 83.07% <ø> (ø)
wysdom/base_schema/SchemaEnum.py 90.47% <90.47%> (ø)
wysdom/__version__.py 100.00% <100.00%> (ø)
wysdom/base_schema/__init__.py 100.00% <100.00%> (ø)
wysdom/dom/DOMElement.py 90.32% <100.00%> (+2.82%) ⬆️
wysdom/dom/DOMList.py 75.00% <100.00%> (ø)
wysdom/object_schema/resolve_arg_to_type.py 94.11% <100.00%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a521c6...a35045c. Read the comment docs.

@jtv8 jtv8 merged commit 741edf5 into master Mar 12, 2021
@jtv8 jtv8 deleted the issue-61-Allow_property_type_in_UserProperty_to_be_a_Python_enum_and_translate_it_to_a_jsonschema_enum branch May 6, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant