Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow subclasses of UserObjects to be valid input even if they are defined after the object that references them #53

Conversation

jtv8
Copy link
Contributor

@jtv8 jtv8 commented Jan 14, 2021

Resolves #52

@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #53 (a3b387b) into master (f39237e) will decrease coverage by 0.02%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   91.59%   91.56%   -0.03%     
==========================================
  Files          30       30              
  Lines         547      557      +10     
==========================================
+ Hits          501      510       +9     
- Misses         46       47       +1     
Flag Coverage Δ
unittests 91.56% <93.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wysdom/object_schema/SchemaAnyOf.py 90.32% <80.00%> (-2.54%) ⬇️
wysdom/__version__.py 100.00% <100.00%> (ø)
wysdom/user_objects/UserObject.py 98.03% <100.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f39237e...cc31801. Read the comment docs.

@jtv8 jtv8 merged commit 4248f63 into master Jan 14, 2021
@jtv8 jtv8 deleted the issue-52-Subclasses_of_UserObjects_are_omitted_as_valid_input_if_they_are_defined_after_other_UserObjects_that_use_their_superclasses branch March 11, 2021 14:37
@jtv8 jtv8 restored the issue-52-Subclasses_of_UserObjects_are_omitted_as_valid_input_if_they_are_defined_after_other_UserObjects_that_use_their_superclasses branch March 11, 2021 14:37
@jtv8 jtv8 deleted the issue-52-Subclasses_of_UserObjects_are_omitted_as_valid_input_if_they_are_defined_after_other_UserObjects_that_use_their_superclasses branch March 11, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant