Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add persist_defaults param to UserProperty #45

Conversation

jtv8
Copy link
Contributor

@jtv8 jtv8 commented Jun 13, 2020

Closes #43
Closes #44

@codecov
Copy link

codecov bot commented Jun 13, 2020

Codecov Report

Merging #45 into master will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage   90.17%   90.29%   +0.12%     
==========================================
  Files          30       30              
  Lines         529      536       +7     
==========================================
+ Hits          477      484       +7     
  Misses         52       52              
Flag Coverage Δ
#unittests 90.29% <100.00%> (+0.12%) ⬆️
Impacted Files Coverage Δ
wysdom/__version__.py 100.00% <100.00%> (ø)
wysdom/user_objects/UserProperty.py 94.11% <100.00%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66a9251...ab096cd. Read the comment docs.

@jtv8 jtv8 merged commit 4e01aab into master Jun 13, 2020
@jtv8 jtv8 deleted the issue-43-Return_type_of_UserProperty_defaults_should_always_be_property_type branch March 11, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant