Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 5 use references when building json schemas to avoid infinite recursion #33

Conversation

jtv8
Copy link
Contributor

@jtv8 jtv8 commented May 23, 2020

Closes #5
Closes #29
Closes #32
Closes #35

@codecov
Copy link

codecov bot commented May 23, 2020

Codecov Report

Merging #33 into master will increase coverage by 2.70%.
The diff coverage is 94.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   85.50%   88.21%   +2.70%     
==========================================
  Files          31       30       -1     
  Lines         483      509      +26     
==========================================
+ Hits          413      449      +36     
+ Misses         70       60      -10     
Flag Coverage Δ
#unittests 88.21% <94.66%> (+2.70%) ⬆️
Impacted Files Coverage Δ
wysdom/base_schema/SchemaNone.py 100.00% <ø> (ø)
wysdom/base_schema/SchemaType.py 90.00% <ø> (ø)
wysdom/dom/DOMDict.py 80.95% <ø> (-19.05%) ⬇️
wysdom/dom/DOMList.py 69.01% <ø> (-5.99%) ⬇️
wysdom/mixins/ReadsJSON.py 100.00% <ø> (ø)
wysdom/mixins/ReadsYAML.py 100.00% <ø> (ø)
wysdom/mixins/RegistersSubclasses.py 74.07% <66.66%> (+14.07%) ⬆️
wysdom/__init__.py 100.00% <100.00%> (ø)
wysdom/__version__.py 100.00% <100.00%> (ø)
wysdom/base_schema/Schema.py 92.59% <100.00%> (+5.92%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f70718c...9938031. Read the comment docs.

@jtv8 jtv8 merged commit 0350c68 into master May 23, 2020
@jtv8 jtv8 deleted the issue-5-Use_references_when_building_JSON_schemas_to_avoid_infinite_recursion branch May 23, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant