Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect schema dict for arrays, rename Schema.schema to jsonschema_dict #30

Merged

Conversation

jtv8
Copy link
Contributor

@jtv8 jtv8 commented May 22, 2020

…for clarity, documented Schema class

Closes #10

…schema_dict for clarity, documented Schema class
@jtv8 jtv8 linked an issue May 22, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #30 into master will increase coverage by 1.16%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   82.02%   83.19%   +1.16%     
==========================================
  Files          31       31              
  Lines         484      476       -8     
==========================================
- Hits          397      396       -1     
+ Misses         87       80       -7     
Flag Coverage Δ
#unittests 83.19% <84.61%> (+1.16%) ⬆️
Impacted Files Coverage Δ
wysdom/base_schema/SchemaNone.py 100.00% <ø> (+37.50%) ⬆️
wysdom/base_schema/SchemaType.py 90.00% <ø> (ø)
wysdom/base_schema/Schema.py 86.66% <71.42%> (+2.05%) ⬆️
wysdom/base_schema/SchemaAnything.py 83.33% <100.00%> (+8.33%) ⬆️
wysdom/base_schema/SchemaConst.py 77.77% <100.00%> (+16.23%) ⬆️
wysdom/base_schema/SchemaPrimitive.py 100.00% <100.00%> (ø)
wysdom/object_schema/SchemaAnyOf.py 55.55% <100.00%> (ø)
wysdom/object_schema/SchemaArray.py 100.00% <100.00%> (ø)
wysdom/object_schema/SchemaObject.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea31416...08d3408. Read the comment docs.

@jtv8 jtv8 merged commit ca84721 into master May 22, 2020
@jtv8 jtv8 deleted the issue-10-Schemas_for_array_items_do_not_resolve_to_Python_dicts branch May 22, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schemas for array items do not resolve to Python dicts
1 participant