Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmos V4: Reduce initialization confusion #208

Merged
merged 17 commits into from
Apr 7, 2020
Merged

Cosmos V4: Reduce initialization confusion #208

merged 17 commits into from
Apr 7, 2020

Conversation

bartelink
Copy link
Collaborator

@bartelink bartelink commented Mar 20, 2020

re #197 This addresses a longstanding mess in Cosmos.fs wrt how initialization is managed
@ylibrach this has placeholder names that would benefit from some pairing if you're up for it ;)

@bartelink bartelink requested a review from ylibrach March 20, 2020 20:59
@bartelink bartelink changed the title Cosmos V4: Remove initialization confusion Cosmos V4: Reduce initialization confusion Mar 20, 2020
Copy link

@ylibrach ylibrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bartelink from what I can tell, this removes the ability for the consumer to provide their own implementation of ContainerGateway, which was the whole point of the client abstractions work. Unless I'm not seeing something?

@bartelink
Copy link
Collaborator Author

Apologies; Its possible that it's not wired through, and I agree its a pretty big gap
(I was parking that final wiring work pending your high level review at the time (and it was definitely dark outside ;) ))

@bartelink
Copy link
Collaborator Author

The above exposes a createGateway argument on the Equinox.Cosmos.Client - can you see if it looks right please? @ylibrach
Feel free to merge and/or post follow-up comments or commits as you see fit...

@bartelink
Copy link
Collaborator Author

More stuff will likely happen to more closely align with https://azure.github.io/azure-sdk/dotnet_introduction.html before a V3 beta...

@bartelink
Copy link
Collaborator Author

Merging as agreed out of band with @ylibrach - some naming and signature changes will follow as independent PRs

@bartelink bartelink merged commit 07c8492 into cosmossdk4 Apr 7, 2020
@bartelink bartelink deleted the cleanup branch April 7, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants