Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tip compression toggle through optional argument #206

Merged
merged 5 commits into from
Mar 19, 2020

Conversation

ylibrach
Copy link

@ylibrach ylibrach commented Mar 18, 2020

This PR adds an optional compress argument to the Resolver's Resolve method, which defaults to true. Setting it to false will make it so that the data and metadata payloads of the Unfold within the Tip are stored in CosmosDB as uncompressed and unencoded.

Copy link
Collaborator

@bartelink bartelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat
Would be nice to see a mirror against the v2 branch too - time for us to broaden the circle with an up-for-grabs good-first-issue Issue! ;)

src/Equinox.Cosmos/Cosmos.fs Show resolved Hide resolved
src/Equinox.Cosmos/Cosmos.fs Outdated Show resolved Hide resolved
tests/Equinox.Cosmos.Integration/JsonConverterTests.fs Outdated Show resolved Hide resolved
@ylibrach ylibrach marked this pull request as ready for review March 19, 2020 15:07
@ylibrach ylibrach merged commit a188f69 into client-abstractions Mar 19, 2020
@bartelink bartelink deleted the tip-compress-toggle branch March 19, 2020 17:14
bartelink pushed a commit that referenced this pull request Oct 2, 2020
bartelink pushed a commit that referenced this pull request Oct 2, 2020
bartelink added a commit that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants