-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UnionConverter: Handle Nested Unions #52
Conversation
CC @gardito @fnipo @NickDarvey I can't think of a cleaner way to manage this, thoughts? |
You could maybe check that the |
@NickDarvey Hm, that's a damn good question. I'm not sure I know the answer so I did b77261f instead. I tried to extend the check in the way you suggested, but ran aground and then ran out of time :( An example case my hack does not address is allowing conversions implemented as a I'm thinking some mix of having tighter rules in #50 and trying to strip down the impl in #43 may be some of the answer. For now, I need to ship this so its 🙈for the moment... |
Nested unions don't roundtrip; this PR addresses that by removing the inlining of nested objects when a converter is in play