This repository has been archived by the owner on Nov 20, 2020. It is now read-only.
Feature: LimitBy / BulkheadMultiAsync #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartelink
force-pushed
the
feature/bulkhead-multi
branch
from
424f277 to
23078ec
Compare
bartelink
force-pushed
the
feature/bulkhead-multi
branch
6 times, most recently
from
0d3f118 to
67204e2
Compare
bartelink
requested review from
troykershaw,
gusty and
eulerfx
and removed request for
gusty
gusty
approved these changes
Oct 25, 2018
bartelink
force-pushed
the
master
branch
12 times, most recently
from
ba7980e to
0f40396
Compare
bartelink
force-pushed
the
feature/bulkhead-multi
branch
2 times, most recently
from
80bd88b to
520c40d
Compare
bartelink
force-pushed
the
feature/bulkhead-multi
branch
from
520c40d to
cca28e2
Compare
bartelink
force-pushed
the
feature/bulkhead-multi
branch
2 times, most recently
from
b6ac241 to
209de4e
Compare
bartelink
force-pushed
the
feature/bulkhead-multi
branch
from
209de4e to
0210204
Compare
|
Tests are flickering (I've had to relax yet more constraints in here). Cannot reproduce failures locally :( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a
LimitByrule to go with the currentLimitrule as noted in #15. The implementation implements the key underlying primitiveBulkheadMultiin style approximating that of Polly roughly in line with what I posted as App-vNext/Polly#507.If this proves to work well and gains traction in terms of actual usage, the medium term intent should be to work with Polly folk to do a full idiomatic implementation in Polly itself and consume that within CallPolly.