-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove es5 builds #9945
Remove es5 builds #9945
Conversation
Note: I left the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Aw, the only feature I added to Jest... I should probably have added some documentation for it though. ;) But I agree that it makes sense to remove now. |
@skovhus thank you for your contribution to Jest all those years ago. It was very useful when Jest was still gaining adoption. Nowadays everyone is using a bundler so they can compile these themselves. |
It is always nice when you can remove code. 👏 |
:( we were using these (sorry we've just upgraded). Compiling them is not hard, but these were also stubbing out chalk, which is a paaaaaain to do ourselves |
you can just copy the fake chalk we used and do module replacement. You can look at the PR that added it for (Seems we haven't even removed it from our sources, which we should do.) |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
We have shipped es5 builds for a very long time but they receive little usage. Their original intent was to enable people to load these packages into the browser without transformation. Nowadays most browsers support latest syntax features and app developers have bundlers available to compile and bundle npm packages. With this change, we are pushing the responsibility to bundle the affected packages themselves rather than Jest providing them out of the box.
This change will be part of Jest 26.
Test plan
The code has been terminated.