Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump to istanbul alphas #9192

Merged
merged 6 commits into from
Nov 20, 2019
Merged

chore: bump to istanbul alphas #9192

merged 6 commits into from
Nov 20, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Nov 16, 2019

Summary

/cc @coreyfarrell. I've updated some snapshots that looked correct, but left a few alone. I'll update after you've fixed the sourceFinder issue

Test plan

Green CI. We'll need to figure out what to do about TS types. Should probably wait for this to be stable as well. We can upgrade without a new major anyways as this is all internal stuff. I wouldn't consider changes in the coverage report to be breaking

@coreyfarrell
Copy link
Contributor

We can upgrade without a new major anyways as this is all internal stuff.

Only if you've already dropped node.js 6 (these new versions require node.js 8).

@SimenB
Copy link
Member Author

SimenB commented Nov 17, 2019

Yeah, we've landed that on master, just not released yet.


I see we have a windows test failure, though...

image

@codecov-io
Copy link

codecov-io commented Nov 18, 2019

Codecov Report

Merging #9192 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9192      +/-   ##
==========================================
+ Coverage   65.07%   65.08%   +0.01%     
==========================================
  Files         281      278       -3     
  Lines       11864    11861       -3     
  Branches     2920     2922       +2     
==========================================
  Hits         7720     7720              
+ Misses       3515     3512       -3     
  Partials      629      629
Impacted Files Coverage Δ
...ckages/jest-reporters/src/generateEmptyCoverage.ts 88.88% <ø> (ø) ⬆️
packages/jest-reporters/src/coverage_reporter.ts 61.83% <100%> (ø) ⬆️
e2e/babel-plugin-jest-hoist/__test_modules__/b.js
...babel-plugin-jest-hoist/__test_modules__/Mocked.js
e2e/babel-plugin-jest-hoist/__test_modules__/a.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be6df92...9f3f3f2. Read the comment docs.

@SimenB
Copy link
Member Author

SimenB commented Nov 18, 2019

added some ts-ignores just to verify this is good to go beyond type updates, and it seems so

@@ -6990,7 +6990,7 @@ [email protected]:
duplexer "^0.1.1"
pify "^4.0.1"

handlebars@^4.4.0, handlebars@^4.4.2:
handlebars@^4.4.0:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for anyone curious - this comes from https://www.npmjs.com/package/conventional-changelog-writer which comes via lerna, a dev tool. this change means people installing Jest will no longer get handlebars (or uglify)

@SimenB
Copy link
Member Author

SimenB commented Nov 20, 2019

Let's land this so it can be included in the upcoming beta release of jest

@SimenB SimenB marked this pull request as ready for review November 20, 2019 22:22
@SimenB SimenB changed the title WIP istanbul bump chore: bump to istanbul alphas Nov 20, 2019
@SimenB SimenB merged commit fafb5b7 into jestjs:master Nov 20, 2019
@SimenB SimenB deleted the istanbul branch November 20, 2019 22:50
ayush000 added a commit to ayush000/jest that referenced this pull request Nov 21, 2019
* master:
  chore: upgrade to fsevents 2 (jestjs#9215)
  docs: remove expect.assertions(1) in rejects example of Tutoria… (jestjs#9149)
  chore: bump to istanbul alphas (jestjs#9192)
  Fix typo in JestPlatform.md (jestjs#9212)
  jest-snapshot: Ignore indentation for most serialized objects (jestjs#9203)
  fix(jest-types): tighten Config types and set more defaults (jestjs#9200)
  jest-snapshot: Improve colors when snapshots are updatable (jestjs#9132)
  jest-snapshot: Omit irrelevant received properties when property matchers fail (jestjs#9198)
  chore: make changedFiles option optional in `shouldInstrument` (jestjs#9197)
  fix(pretty-format): correctly detect memo (jestjs#9196)
  chore: regenerate lockfiles in e2e tests (jestjs#9193)
  chore: bump handlebars
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants