Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade chalk to v3 #9154

Merged
merged 4 commits into from
Nov 9, 2019
Merged

chore: upgrade chalk to v3 #9154

merged 4 commits into from
Nov 9, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Nov 9, 2019

Summary

It's new and thus better.

https://github.com/chalk/chalk/releases/tag/v3.0.0

Test plan

Green CI

@SimenB
Copy link
Member Author

SimenB commented Nov 9, 2019

@pedrottimark @thymikee could you verify that the snapshot changes in the last commit are sane?

@pedrottimark
Copy link
Contributor

@SimenB Thank you very much! The chalk release comes at a great time for Jest.

Yes, the snapshot changes seem sane as far as this upgrade PR is concerned.

Reading the dense or duplicate codes suggests some clean-up chores in those parts of Jest.

After you merge this pull request, then I will want to merge the changes into #9132

@thymikee thymikee merged commit d7a7b42 into jestjs:master Nov 9, 2019
@SimenB SimenB deleted the chalk-v3 branch November 9, 2019 20:09
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants