Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow --testURL as a valid CLI option #8908

Closed
wants to merge 5 commits into from
Closed

Conversation

cchanse
Copy link

@cchanse cchanse commented Sep 3, 2019

Summary

Allow --testURL as a CLI option. Using --testURL currently results in Unrecognized CLI Parameter

Fixes #8889

Test plan

Install jest and then run jest --testURL "https://localhost"

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-io
Copy link

codecov-io commented Sep 3, 2019

Codecov Report

Merging #8908 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8908      +/-   ##
==========================================
- Coverage   64.24%   64.23%   -0.02%     
==========================================
  Files         275      275              
  Lines       11656    11658       +2     
  Branches     2844     2845       +1     
==========================================
  Hits         7488     7488              
- Misses       3544     3546       +2     
  Partials      624      624
Impacted Files Coverage Δ
packages/jest-validate/src/validateCLIOptions.ts 65.78% <ø> (ø) ⬆️
packages/jest-snapshot/src/index.ts 28.66% <0%> (-0.2%) ⬇️
packages/jest-snapshot/src/State.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c588c18...7e0f970. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG.md Outdated
@@ -13,6 +13,7 @@

### Fixes

- `[jest-validate]` Allow --testURL as a CLI option ([#8908](https://github.com/facebook/jest/pull/8908))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make sure to sort the entries alphabetically?

@codecov-commenter
Copy link

Codecov Report

Merging #8908 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8908   +/-   ##
=======================================
  Coverage   64.23%   64.23%           
=======================================
  Files         275      275           
  Lines       11658    11658           
  Branches     2845     2845           
=======================================
  Hits         7488     7488           
  Misses       3546     3546           
  Partials      624      624           
Impacted Files Coverage Δ
packages/jest-validate/src/validateCLIOptions.ts 65.78% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4482e71...7e0f970. Read the comment docs.

@SimenB
Copy link
Member

SimenB commented Feb 23, 2022

testURL removed entirely in #10797, so closing

@SimenB SimenB closed this Feb 23, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using --testURL as a CLI option results in Unrecognized CLI Parameter"
5 participants