-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow --testURL as a valid CLI option #8908
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #8908 +/- ##
==========================================
- Coverage 64.24% 64.23% -0.02%
==========================================
Files 275 275
Lines 11656 11658 +2
Branches 2844 2845 +1
==========================================
Hits 7488 7488
- Misses 3544 3546 +2
Partials 624 624
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you add a unit test as well? There is an associated test file: https://github.com/facebook/jest/blob/8e0786fdbc80ec993707fbb36495143e4e043952/packages/jest-validate/src/__tests__/validateCLIOptions.test.js
CHANGELOG.md
Outdated
@@ -13,6 +13,7 @@ | |||
|
|||
### Fixes | |||
|
|||
- `[jest-validate]` Allow --testURL as a CLI option ([#8908](https://github.com/facebook/jest/pull/8908)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you make sure to sort the entries alphabetically?
Codecov Report
@@ Coverage Diff @@
## master #8908 +/- ##
=======================================
Coverage 64.23% 64.23%
=======================================
Files 275 275
Lines 11658 11658
Branches 2845 2845
=======================================
Hits 7488 7488
Misses 3546 3546
Partials 624 624
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Allow --testURL as a CLI option. Using
--testURL
currently results inUnrecognized CLI Parameter
Fixes #8889
Test plan
Install jest and then run jest --testURL "https://localhost"