-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timeout to prevent notifier from locking CPU on MacOS #8831
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the changelog as well 🙂
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Maybe bump the dependency to the latest as well, while we're here? https://github.com/facebook/jest/blob/3ab2fc1b0ae3542bb8cdc927bf5459ba16a6420c/packages/jest-reporters/package.json#L25 |
This is not an issue for the RN CLI, right? Since they don't use https://github.com/react-native-community/cli/blob/4d38c4cdb5a1e05c6670a046ef5a44afd655111a/packages/cli/package.json#L51 |
@SimenB It doesn't seem like it. You can verify blocking vs. non-blocking by saving and running the script below with const process = require("process")
const notifier = require("node-notifier")
let args = {
closeLabel: "Close",
message: "⛔️ 1 of 9 tests failed",
title: "12% Failed"
}
if (process.argv[2] === "with-actions") {
console.log("Called with actions")
args = Object.assign(args, { actions: ["Run again", "Exit tests"] })
} else {
console.log("Called without actions")
}
notifier.notify(args, () => {}) |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
See discussion #8830