pretty-format: replace left-pad with String.prototype.padStart()

[sidoruk-sv]

fix #8516

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[jeysal]

Thanks a lot! Did you run Yarn to update the lockfile?
Also note that I think there's also a dependency on left-pad via an outdated jsdom, so until we can update that users will probably still see warnings sometimes

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[codecov-io]

Codecov Report

Merging #8517 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8517   +/-   ##
=======================================
  Coverage   60.56%   60.56%           
=======================================
  Files         269      269           
  Lines       11045    11045           
  Branches     2690     2690           
=======================================
  Hits         6689     6689           
  Misses       3770     3770           
  Partials      586      586

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44a13e7...2e2e801. Read the comment docs.

[sidoruk-sv]

@jeysal yarn.lock updated too

[jeysal]

Thanks! Should wait for #8455 then we can merge this. (padStart is Node 8+)

[SimenB]

Oh sorry, I forgot about this PR 😬 I fixed it as part of #8850

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.