Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: leave single 22.x in versioned docs #7674

Merged
merged 4 commits into from
Jan 22, 2019
Merged

chore: leave single 22.x in versioned docs #7674

merged 4 commits into from
Jan 22, 2019

Conversation

thymikee
Copy link
Collaborator

Summary

Jest 22 is pretty old already and we don't need granular history of changes between minor versions.

Test plan

This is a test before removing 23.x the same way once 24 is released

@thymikee thymikee force-pushed the docs/remove-22-minor-versioning branch from 8cd822e to 8d5ea06 Compare January 21, 2019 20:00
@SimenB
Copy link
Member

SimenB commented Jan 21, 2019 •
edited
Loading

Did you try yarn start in website/ locally? Seems like the build failed

Also: 🚀

@thymikee
Copy link
Collaborator Author

Too lazy, wanted netlify to do it for me, but you've got the point

@rickhanlonii
Copy link
Member

Did you keep the latest Jest 22 version?

@SimenB
Copy link
Member

SimenB commented Jan 21, 2019

That's what I wanted to check as well 😀 We should keep a 22.x around, which would be the latest we have now (22.4) (likewise keep 23.x for 23.6 after 24 is out)

@thymikee
Copy link
Collaborator Author

Ok, running it locally uncovered some issues which are now fixed, so should be better now :)

SimenB
SimenB approved these changes Jan 21, 2019
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Only comment is, could we have 22.x instead of 22.4? Potentially just 22?

@thymikee thymikee changed the title chore: remove 22.x from versioned docs chore: leave single 22.x in versioned docs Jan 21, 2019
@rickhanlonii
Copy link
Member

22.x is wrong though for x < 4

@thymikee
Copy link
Collaborator Author

thymikee commented Jan 21, 2019 •
edited
Loading

So, should we use 22.x or 22.4? I'd go with 22.x, just like https://reactnavigation.org/en/versions.html does

I removed the <=22.x thing. It's just 22.x now.

@thymikee thymikee force-pushed the docs/remove-22-minor-versioning branch from 1601008 to 3af36cd Compare January 21, 2019 21:44
@SimenB
Copy link
Member

SimenB commented Jan 22, 2019

🤐

@SimenB SimenB merged commit 05e8ac0 into jestjs:master Jan 22, 2019
captain-yossarian pushed a commit to captain-yossarian/jest that referenced this pull request Jul 18, 2019
@thymikee @captain-yossarian
chore: leave single 22.x in versioned docs (jestjs#7674)
bedf3ce
BogdanDor added a commit to BogdanDor/jest that referenced this pull request Jul 27, 2020
@BogdanDor
docs: restore deleted page
5ea02fc 
After jestjs#7674 files versioned_docs/version-22.2/Es6ClassMocks.md and versioned_docs/version-22.3/Es6ClassMocks.md were deleted.
website/versioned_sidebars/version-22.x-sidebars.json contains stirng "version-22.x-es6-class-mocks",
but needed file doesn't exists in directory.
@BogdanDor BogdanDor mentioned this pull request Jul 27, 2020
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

@rickhanlonii rickhanlonii Awaiting requested review from rickhanlonii

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thymikee @SimenB @rickhanlonii @facebook-github-bot