-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove jest-editor-support and jest-test-typescript-parser from the repo #7232
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7232 +/- ##
==========================================
- Coverage 67.27% 66.49% -0.78%
==========================================
Files 248 237 -11
Lines 9652 9302 -350
Branches 3 3
==========================================
- Hits 6493 6185 -308
+ Misses 3158 3116 -42
Partials 1 1 Continue to review full report at Codecov.
|
Thanks man, yeah, I've been wondering if it even needs to exist, we originally didn't include it so that the jest set of repos didn't include typescript and now that problem doesn't exist - so should be fine |
OK, let's get this done - note: e9818dc is the last commit with it included (for the final bits of porting) |
@orta, vscode-jest uses If you plan to move to babel-7, then you can consider using its new typescript plugin, however you will probably need to do some test to ensure this new babel's plugin is as capable as the typescript parser used in if you are not ready to move to babel-7/babel-typescript-plugin and do all the testing, then we should probably port |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This has been extracted out: https://github.com/jest-community/jest-editor-support
@orta we should probably create something for
jest-test-typescript-parser
as well?Test plan
Green CI (I haven't ran the tests locally, but I don't think we had any e2e tests for this?)