Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move jest-each to core #6278

Merged
merged 17 commits into from
May 27, 2018
Merged

Move jest-each to core #6278

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d607493
Copy jest-each into jest core
mattphillips May 26, 2018
dae5dbd
Add npm ignore to jest-each
mattphillips May 26, 2018
4a0d2fe
Update package to follow jest standards
mattphillips May 26, 2018
2b02670
Remove examples from jest-each
mattphillips May 26, 2018
47d5150
Remove nested gitignore
mattphillips May 26, 2018
1c4e907
Remove licenses and broken links
mattphillips May 26, 2018
061cdcb
Replace vsprint for node util
mattphillips May 26, 2018
5ecdcaa
Move jest-each tests to __tests__ folder
mattphillips May 26, 2018
c231b93
Remove ci build
mattphillips May 26, 2018
bf85fe7
Remove lockfile
mattphillips May 26, 2018
4e8864b
Fix lint errors
mattphillips May 26, 2018
d5fae40
Fix object spread/rest with Object.assign
mattphillips May 26, 2018
3e30540
Add changelog entry
mattphillips May 26, 2018
3d3da16
Add mocks to be ignored
mattphillips May 27, 2018
b5989ac
Update version to 23
mattphillips May 27, 2018
5b0379e
Update change to be a chore
mattphillips May 27, 2018
9d40446
Fix mardown linting
mattphillips May 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
## master

### Features

* `[jest-each]` Move jest-each into core Jest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Move `jest-each` into Jest core

?

Copy link
Collaborator

@thymikee thymikee May 26, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I think this is more of a chore action, but I'm probably wrong. cc @SimenB

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree - the feature has already landed in Jest, moving this package in is just a step on the way for circus to get the feature as well

([#6278](https://github.com/facebook/jest/pull/6278))

## 23.0.0

### Features
Expand Down
3 changes: 3 additions & 0 deletions packages/jest-each/.npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
**/__tests__/**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add **/__mocks__/** just in case

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, this should copy all of the other npmignores, but add asset in addition to them

src
assets
Loading