-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-fix] Update Troubleshooting section for VSCode #5195
[docs-fix] Update Troubleshooting section for VSCode #5195
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #5195 +/- ##
======================================
Coverage 60.8% 60.8%
======================================
Files 201 201
Lines 6707 6707
Branches 3 3
======================================
Hits 4078 4078
Misses 2628 2628
Partials 1 1 Continue to review full report at Codecov.
|
@@ -129,8 +129,7 @@ can debug your Jest tests with the following configuration: | |||
"type": "node", | |||
"request": "launch", | |||
"runtimeExecutable": "${workspaceRoot}/node_modules/.bin/react-scripts", | |||
"runtimeArgs": ["--inspect-brk", "test"], | |||
"args": ["--runInBand", "--no-cache", "--env=jsdom"], | |||
"args": ["test", "--runInBand", "--no-cache", "--env=jsdom"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should test
be there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know yes, as that's the exact example I got from VS Code's reply on the issue : microsoft/vscode#40896
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't use vs code, seems reasonable, though
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Hi @SimenB
This is a PR that stems from #5193
Summary
With the newest release of VS Code (1.19.1) the example configuration for debugging Jest tests no longer works. VS Code have kindly provided a new configuration that I've checked and confirmed that works with the latest VS Code.
Screenshot of updated docs section: