-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port 'beforeAll on disabled test' fixed from jasmine #5051
Conversation
@k15a as you can probably already be aware of, this is failing on CI because of Prettier lint. Can you run |
The new test is also failing, it's not just lint, unfortunately |
@@ -1,11 +1,13 @@ | |||
describe("abc", function() { | |||
it("runs abc", function() {}); | |||
/* globals fail */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpojer yet another jasmine global... Can we add it to the jest
global?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather just kill this one and provide a better API tbh.
So I've had a deeper look but I can't figure out how to fix this issue. The fix that worked for jasmine seems to not work for the jest fork. |
Yeah, seems like this is not the right fix for Jest. I'll close this PR but we should still find a way to fix the original issue. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I've ported the changes from https://github.com/jasmine/jasmine/pull/1225/files to jest but it seems like they are not fixing the issue at #4820.