Add missing escape sequences to ConvertAnsi plugin #4544
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
close
sequences, some closing tags didn’t match opening tagsclose
sequences (which are shared, by the way) forbold
anddim
their opening tags didn’t match closing tagsThe mismatches confused me a bit in the beginning.
Adding the missing
cyan
theme color confused us when we reviewed #3429Additional colors:
gray
(also known as bright black) in default theme forpretty-format
pluginyellow
in default theme forpretty-format
plugin also injest-diff
white
injest-cli
Additional modifier:
inverse
is used injest-cli
also will be useful injest-diff
andjest-matcher-utils
Additional
close
sequences:bold
dim
Residue: While reviewing the snapshots, a few mismatched
</>
confused me becausereset.open
andreset.close
share the same escape sequence.Test plan
Ouch: 511 snapshots updated in 15 test suites