Call same printChildren as for React in HTMLElement plugin #4275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3825
If highest priority is to accurately serialize HTML rendered by React or other frameworks:
For a while, I thought we could “have our cake and eat it too” for static-site HTML by removing newlines followed by even number of spaces with
/\n+( {2})*/
pattern, but newline and indentation precedingspan
in syntax-highlightedpre
is a counterexample.Residue
lib/markup.js
especially affecting HTMLREADME.md
after Add Usage in Jest to pretty-format/README.md #4253 has been mergedTest plan
Local
yarn test
has one failure probably related to #4254 [have merged fix from master]Updated existing tests to call
createTextNode
method:Updated existing tests to specify improved formatting:
Added fail-first tests to specify improved formatting:
Added pass-first tests to specify existing formatting: