Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether we should output to stdout or stderr #3953

Merged
merged 1 commit into from
Jul 1, 2017
Merged

Check whether we should output to stdout or stderr #3953

merged 1 commit into from
Jul 1, 2017

Conversation

mjesun
Copy link
Contributor

@mjesun mjesun commented Jun 30, 2017

This PR is related to another two changes deployed this morning: #3945 and #3946. These two had to be rolled back because they were causing issues in CI, however they were working locally.

The cause of the breakage in CI was due to the fact that the is-ci module was not being mocked. Since CI sessions are considered non-interactive, the reporter was not outputting anything and the test failed. After adding a mock to the module (jest.mock('is-ci', () => false)) tests are passing now.

Code for the reporter itself has not been changed when comparing it with the two earlier PRs, so the release done in-between ([email protected]) is safe in that sense.

@codecov-io
Copy link

codecov-io commented Jun 30, 2017

Codecov Report

Merging #3953 into master will increase coverage by 1.8%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3953     +/-   ##
=========================================
+ Coverage   58.06%   59.86%   +1.8%     
=========================================
  Files         196      196             
  Lines        6758     6763      +5     
  Branches        6        6             
=========================================
+ Hits         3924     4049    +125     
+ Misses       2831     2711    -120     
  Partials        3        3
Impacted Files Coverage Δ
...ackages/jest-cli/src/reporters/default_reporter.js 91.04% <100%> (+86.2%) ⬆️
packages/jest-cli/src/reporters/utils.js 62.5% <0%> (+2.08%) ⬆️
packages/jest-cli/src/reporters/base_reporter.js 80% <0%> (+20%) ⬆️
...ckages/jest-cli/src/reporters/get_result_header.js 78.57% <0%> (+50%) ⬆️
packages/jest-cli/src/reporters/status.js 93.75% <0%> (+89.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44c3c9d...66016de. Read the comment docs.

@mjesun mjesun requested a review from cpojer June 30, 2017 19:33
@cpojer cpojer merged commit b079d2a into jestjs:master Jul 1, 2017
@mjesun mjesun deleted the fix-reporter branch July 3, 2017 10:37
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants